Skip to content

feat: tab reordering via drag-n-drop.#70

Merged
knightedcodemonkey merged 3 commits into
nextfrom
bananas
Apr 11, 2026
Merged

feat: tab reordering via drag-n-drop.#70
knightedcodemonkey merged 3 commits into
nextfrom
bananas

Conversation

@knightedcodemonkey

@knightedcodemonkey knightedcodemonkey commented Apr 11, 2026

Copy link
Copy Markdown
Owner

Copilot AI review requested due to automatic review settings April 11, 2026 20:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds drag-and-drop tab reordering to the workspace tab strip, persisting the new order via the existing workspace save/reload flow.

Changes:

  • Make workspace tabs draggable and implement drag/drop handlers to reorder tabs.
  • Add visual affordances for dragging (grab cursor, drag-over outline).
  • Add Playwright coverage for reordering persistence and no-op self-drop behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/styles/panels-editor.css Adds drag cursor + drag-over outline styling for workspace tabs.
src/modules/workspace-tabs-state.js Introduces moveTabBefore() to reorder tabs in state.
src/app.js Implements drag/drop UI behavior and triggers persistence after reorder.
playwright/workspace-tabs.spec.ts Adds end-to-end tests validating reorder behavior across reload and self-drop no-op.
playwright/helpers/app-test-helpers.ts Adds a helper to perform drag-to reorder in tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/app.js
Comment thread src/app.js Outdated
@knightedcodemonkey knightedcodemonkey merged commit fd9a617 into next Apr 11, 2026
5 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch April 11, 2026 21:12
knightedcodemonkey added a commit that referenced this pull request May 2, 2026
* feat: idb infrastructure. (#63)

* feat: dynamic tabs. (#64)

* refactor: better accessbility for tabs. (#68)

* feat: remove allow-same-origin for better security. (#69)

* feat: tab reordering via drag-n-drop. (#70)

* feat: explicit css imports, diagnostics per editor buffer. (#71)

* feat: idb + github sync with atomic open and push to remote. (#78)

* closes #73, closes #74, closes #75.

* refactor: more colocation and smaller file sizes. (#79)

* refactor: improvements with styles and gh syncs. (#82)

* test: webkit flake. (#83)

* test: address flake. (#84)

* refactor: github pr context. (#85)

* fix: require app in entry, hide workspaces without pat, remove star important. (#86)

* feat: make idb source of truth for pr context. (#87)

* fix: active pr context on reload and dedupe workspace identity. (#88)

* fix: edited and push sync across reloads. (#89)

* fix: properly commit tab name changes. (#90)

* fix(tabs): filename edits, min-widths, scrolling, content sync. (#91)

* feat: improved workspace disconnect and closed ux. (#92)

* refactor: status styling and biome config. (#94)

* fix(diagnostics): enforce current-editor snapshots and stale results. (#95)

* fix: consistent head handling. (#96)

* fix: prevent workspace overwrites. (#100)

* fix(playwright): stabilize lint diagnostics waits with one-time rerun fallback. (#101)

* feat: improved workspace ux and state identity separation.  (#103)

* fix: iframe protocol mismatch in receiver reads. (#104)

* refactor: remove remaining fixed editor assumptions. (#105)

* refactor: simplify PR close flow with deterministic workspace state updates (#106)

* feat: mode-aware entry tab extensions. (#108)

* feat: workspace status bar. (#109)

* feat: tab-scoped ai chat. (#111)

* refactor: better workspace drawer ux. (#112)

* refactor: remove collapsible editors and update breakpoint styles. (#113)

* docs: update for vnext. (#114)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants